Linguistic engine: grapheme-aware phonemizer, transitivity-aware grammar, and lyrics loader#12
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codacy's Analysis Summary0 new issue (≤ 0 issue) Review Pull Request in Codacy →
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Motivation
Description
src/UniversalLinguisticEngine.jsby addingvowelTeams,consonantDigraphs,_phonemizePart,_isVowel, and silent-e handling to replace sequential regex-rewrite placeholders._selectEntryand updatedgetFlatGrammarto useAdventries from the lexicon instead of a hardcoded list.src/App.jsxwith a Vite glob-based loader usingimport.meta.glob('/lyrics/*.txt', { as: 'raw' }), including file load error handling, deduplication, and fallback to the embedded corpus.LOGIC-MAP.md,WE-CHOSE.md, andTESTING.mdwith logic chains and a non-mock test matrix.Testing
TESTING.mdwas updated with concrete, non-mock test cases foranalyze()(e.g.,analyze('cake'),analyze('rain'),analyze('shadow')) and generation edge cases for transitive vs intransitive verbs./lyrics/*.txtresolves to nothing.TESTING.md.Codex Task